refactor: add GET /api/v1/devices/export endpoint - #1209
Open
ShradhaGupta31 wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
+ Coverage 56.71% 58.20% +1.49%
==========================================
Files 149 150 +1
Lines 12154 12329 +175
==========================================
+ Hits 6893 7176 +283
+ Misses 5260 5152 -108
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8 tasks
sudhir-intc
previously requested changes
Aug 26, 2026
ShradhaGupta31
force-pushed
the
device-discovery-exportAPI
branch
from
September 1, 2026 05:21
10f750f to
c2d7a05
Compare
This was referenced Sep 1, 2026
sinchubhat
force-pushed
the
device-discovery-exportAPI
branch
4 times, most recently
from
September 7, 2026 03:43
20b39a8 to
9557963
Compare
sudhir-intc
approved these changes
Sep 8, 2026
ShradhaGupta31
marked this pull request as ready for review
September 8, 2026 07:46
- flat->nested mapping done in one place so SQL and Mongo responses match - me/os/platform/bmc render as null when a subsystem has no data - X-Total-Count header and server-side audit log per export attempt - fields with no writer yet are marked export-map and render null Add the Fuego/OpenAPI declaration and a Postman request asserting the envelope shape, X-Total-Count, and absence of credential fields. Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
- addressed review comments Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
- updated internal/controller/httpapi/v1/devices_test.go Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
Revert the route rename to /api/v1/device-exports. The separate-resource guidance was about the future async job design, not this PR; for now the endpoint stays under /devices since only up to 500 devices are supported synchronously. Signed-off-by: ShradhaGupta31 <shradha.gupta@intel.com>
sinchubhat
force-pushed
the
device-discovery-exportAPI
branch
from
September 9, 2026 03:06
cafe7f8 to
a897fbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #1076
ADR: https://github.com/device-management-toolkit/console/wiki/ADR-devices-export-api